From 3ecde93fd9cfe1fcdbec0f678311c945d783339b Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 4 Aug 2026 09:44:53 +0200 Subject: [PATCH 1/4] Remove useless/confusing const qualifiers The const qualifiers removed here did not qualify what is being pointed to, which is the normal use in function prototypes. Instead, they qualify the variable itself, so that it cannot be changed inside the function. That is itself not wrong, but it's not a normal style, and it seems distracting here. --- src/fe_utils/print.c | 18 +++++++++--------- src/include/fe_utils/print.h | 18 +++++++++--------- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/src/fe_utils/print.c b/src/fe_utils/print.c index 006c026294b..3cb2c5341e8 100644 --- a/src/fe_utils/print.c +++ b/src/fe_utils/print.c @@ -3206,8 +3206,8 @@ ClosePager(FILE *pagerpipe) * table. */ void -printTableInit(printTableContent *const content, const printTableOpt *opt, - const char *title, const int ncolumns, const int nrows) +printTableInit(printTableContent *content, const printTableOpt *opt, + const char *title, int ncolumns, int nrows) { uint64 total_cells; @@ -3254,8 +3254,8 @@ printTableInit(printTableContent *const content, const printTableOpt *opt, * column. */ void -printTableAddHeader(printTableContent *const content, char *header, - const bool translate, const char align) +printTableAddHeader(printTableContent *content, char *header, + bool translate, char align) { #ifndef ENABLE_NLS (void) translate; /* unused parameter */ @@ -3294,8 +3294,8 @@ printTableAddHeader(printTableContent *const content, char *header, * Note: Automatic freeing of translatable strings is not supported. */ void -printTableAddCell(printTableContent *const content, char *cell, - const bool translate, const bool mustfree) +printTableAddCell(printTableContent *content, char *cell, + bool translate, bool mustfree) { uint64 total_cells; @@ -3344,7 +3344,7 @@ printTableAddCell(printTableContent *const content, char *cell, * translated as a whole. */ void -printTableAddFooter(printTableContent *const content, const char *footer) +printTableAddFooter(printTableContent *content, const char *footer) { printTableFooter *f; @@ -3369,7 +3369,7 @@ printTableAddFooter(printTableContent *const content, const char *footer) * around. */ void -printTableSetFooter(printTableContent *const content, const char *footer) +printTableSetFooter(printTableContent *content, const char *footer) { if (content->footers != NULL) { @@ -3387,7 +3387,7 @@ printTableSetFooter(printTableContent *const content, const char *footer) * printTableInit() again. */ void -printTableCleanup(printTableContent *const content) +printTableCleanup(printTableContent *content) { if (content->cellmustfree) { diff --git a/src/include/fe_utils/print.h b/src/include/fe_utils/print.h index 94f6a593619..c437707d5c9 100644 --- a/src/include/fe_utils/print.h +++ b/src/include/fe_utils/print.h @@ -212,18 +212,18 @@ extern void ClosePager(FILE *pagerpipe); extern void html_escaped_print(const char *in, FILE *fout); -extern void printTableInit(printTableContent *const content, +extern void printTableInit(printTableContent *content, const printTableOpt *opt, const char *title, - const int ncolumns, const int nrows); -extern void printTableAddHeader(printTableContent *const content, - char *header, const bool translate, const char align); -extern void printTableAddCell(printTableContent *const content, - char *cell, const bool translate, const bool mustfree); -extern void printTableAddFooter(printTableContent *const content, + int ncolumns, int nrows); +extern void printTableAddHeader(printTableContent *content, + char *header, bool translate, char align); +extern void printTableAddCell(printTableContent *content, + char *cell, bool translate, bool mustfree); +extern void printTableAddFooter(printTableContent *content, const char *footer); -extern void printTableSetFooter(printTableContent *const content, +extern void printTableSetFooter(printTableContent *content, const char *footer); -extern void printTableCleanup(printTableContent *const content); +extern void printTableCleanup(printTableContent *content); extern void printTable(const printTableContent *cont, FILE *fout, bool is_pager, FILE *flog); extern void printQuery(const PGresult *result, const printQueryOpt *opt, base-commit: fef160d8b0ddf72e1089133300d30109293f5a71 -- 2.55.0