From 1ace3a2d29aa96aaa9fc2e33bc75d087f2bf6d61 Mon Sep 17 00:00:00 2001 From: Henson Choi Date: Wed, 10 Jun 2026 16:33:11 +0900 Subject: [PATCH 71/77] Rename allocateRPRPattern to makeRPRPattern in row pattern recognition Rename the pattern allocator to makeRPRPattern, matching the make* naming PostgreSQL uses elsewhere for constructors, and update the stale allocateRPRPattern reference in README.rpr to match. Name change only, no behavior change. --- src/backend/executor/README.rpr | 2 +- src/backend/optimizer/plan/rpr.c | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/backend/executor/README.rpr b/src/backend/executor/README.rpr index c1822d8240b..56ba8550c9c 100644 --- a/src/backend/executor/README.rpr +++ b/src/backend/executor/README.rpr @@ -197,7 +197,7 @@ IV-2. The 6 Phases of buildRPRPattern() Phase 1: AST optimization (optimizeRPRPattern) Phase 2: Statistics collection (scanRPRPattern) - Phase 3: Memory allocation (allocateRPRPattern) + Phase 3: Memory allocation (makeRPRPattern) Phase 4: NFA element fill (fillRPRPattern) Phase 5: Finalization (finalizeRPRPattern) Phase 6: Absorbability analysis (computeAbsorbability) diff --git a/src/backend/optimizer/plan/rpr.c b/src/backend/optimizer/plan/rpr.c index bf537d20c28..a38eb2fd4f0 100644 --- a/src/backend/optimizer/plan/rpr.c +++ b/src/backend/optimizer/plan/rpr.c @@ -73,8 +73,8 @@ static void scanRPRPatternRecursive(RPRPatternNode *node, char **varNames, RPRDepth depth, RPRDepth *maxDepth); static void scanRPRPattern(RPRPatternNode *node, char **varNames, int *numVars, int *numElements, RPRDepth *maxDepth); -static RPRPattern *allocateRPRPattern(int numVars, int numElements, - RPRDepth maxDepth, char **varNamesStack); +static RPRPattern *makeRPRPattern(int numVars, int numElements, + RPRDepth maxDepth, char **varNamesStack); static RPRVarId getVarIdFromPattern(RPRPattern *pat, const char *varName); static bool fillRPRPatternVar(RPRPatternNode *node, RPRPattern *pat, int *idx, RPRDepth depth); @@ -1124,15 +1124,15 @@ scanRPRPattern(RPRPatternNode *node, char **varNames, int *numVars, } /* - * allocateRPRPattern + * makeRPRPattern * Allocate and initialize RPRPattern structure. * * Creates the pattern structure, copies variable names, and allocates * the elements array. The elements array is zero-initialized. */ static RPRPattern * -allocateRPRPattern(int numVars, int numElements, RPRDepth maxDepth, - char **varNamesStack) +makeRPRPattern(int numVars, int numElements, RPRDepth maxDepth, + char **varNamesStack) { RPRPattern *result; int i; @@ -1942,7 +1942,7 @@ buildRPRPattern(RPRPatternNode *pattern, List *defineVariableList, scanRPRPattern(optimized, varNamesStack, &numVars, &numElements, &maxDepth); /* Allocate result structure */ - result = allocateRPRPattern(numVars, numElements, maxDepth, varNamesStack); + result = makeRPRPattern(numVars, numElements, maxDepth, varNamesStack); /* Fill elements (pass 2) */ idx = 0; -- 2.50.1 (Apple Git-155)