From 2454614eee0187104518afc28d62f2571fc82ff9 Mon Sep 17 00:00:00 2001 From: Jim Jones Date: Wed, 20 May 2026 08:50:15 +0200 Subject: [PATCH v5] Fix psql duplicate items for \dRp+ and \d When a publication pub1 is defined using both "TABLES IN SCHEMA myschema", and "TABLE myschema.t1", it caused duplicated items in the psql describe output. This patch simplifies the output and aligns better with the documentation. Now: "\dRp+ pub1" shows only Schema "myschema", not also Table "myschema.t1" "\d t1" shows Publication "pub1" only once Author: Peter Smith Co-author: Jim Jones Discussion: https://www.postgresql.org/message-id/flat/CAHut%2BPvSOmRrQX%2BVrFYHtFipV9hM%3Dp99FeOwYCzkuU2BOaLu7Q%40mail.gmail.com --- src/bin/psql/describe.c | 15 ++++++++++-- src/test/regress/expected/publication.out | 29 ++++++++++++++++++----- src/test/regress/sql/publication.sql | 5 ++++ 3 files changed, 41 insertions(+), 8 deletions(-) diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c index e1449654f96..e326daf632f 100644 --- a/src/bin/psql/describe.c +++ b/src/bin/psql/describe.c @@ -3199,7 +3199,12 @@ describeOneTableDetails(const char *schemaname, "FROM pg_catalog.pg_publication p\n" " JOIN pg_catalog.pg_publication_rel pr ON p.oid = pr.prpubid\n" " JOIN pg_catalog.pg_class c ON c.oid = pr.prrelid\n" - "WHERE pr.prrelid = '%s'\n", + "WHERE pr.prrelid = '%s'\n" + " AND NOT EXISTS (\n" + " SELECT 1\n" + " FROM pg_catalog.pg_publication_namespace pn\n" + " WHERE pn.pnpubid = p.oid\n" + " AND pn.pnnspid = c.relnamespace)\n", oid, oid, oid); if (pset.sversion >= 190000) @@ -7015,7 +7020,13 @@ describePublications(const char *pattern) " pg_catalog.pg_publication_rel pr\n" "WHERE c.relnamespace = n.oid\n" " AND c.oid = pr.prrelid\n" - " AND pr.prpubid = '%s'\n", pubid); + " AND pr.prpubid = '%s'\n" + " AND NOT EXISTS (\n" + " SELECT 1\n" + " FROM pg_catalog.pg_publication_namespace pn\n" + " WHERE pn.pnpubid = pr.prpubid\n" + " AND pn.pnnspid = c.relnamespace)\n", + pubid); if (pset.sversion >= 190000) appendPQExpBufferStr(&buf, " AND NOT pr.prexcept\n"); diff --git a/src/test/regress/expected/publication.out b/src/test/regress/expected/publication.out index 29e54b214a0..9c6386d518a 100644 --- a/src/test/regress/expected/publication.out +++ b/src/test/regress/expected/publication.out @@ -146,11 +146,22 @@ RESET client_min_messages; Owner | All tables | All sequences | Inserts | Updates | Deletes | Truncates | Generated columns | Via root | Description --------------------------+------------+---------------+---------+---------+---------+-----------+-------------------+----------+------------- regress_publication_user | f | f | t | t | t | t | none | f | -Tables: - "pub_test.testpub_nopk" Tables from schemas: "pub_test" +-- table also covered by a published schema should appear only once in \d output +\d pub_test.testpub_nopk + Table "pub_test.testpub_nopk" + Column | Type | Collation | Nullable | Default +--------+---------+-----------+----------+--------- + foo | integer | | | + bar | integer | | | +Included in publications: + "testpub_for_tbl_schema" + "testpub_foralltables" + "testpub_forschema" + "testpub_fortable" + -- weird parser corner case CREATE PUBLICATION testpub_parsertst FOR TABLE pub_test.testpub_nopk, CURRENT_SCHEMA; ERROR: invalid table name @@ -167,8 +178,6 @@ ALTER PUBLICATION testpub_forschema ADD TABLE pub_test.testpub_nopk; Owner | All tables | All sequences | Inserts | Updates | Deletes | Truncates | Generated columns | Via root | Description --------------------------+------------+---------------+---------+---------+---------+-----------+-------------------+----------+------------- regress_publication_user | f | f | t | t | t | t | none | f | -Tables: - "pub_test.testpub_nopk" Tables from schemas: "pub_test" @@ -832,11 +841,19 @@ RESET client_min_messages; Owner | All tables | All sequences | Inserts | Updates | Deletes | Truncates | Generated columns | Via root | Description --------------------------+------------+---------------+---------+---------+---------+-----------+-------------------+----------+------------- regress_publication_user | f | f | t | t | t | t | none | f | -Tables: - "testpub_rf_schema2.testpub_rf_tbl6" WHERE (i < 99) Tables from schemas: "testpub_rf_schema2" +-- table with a row-filter, also covered by a published schema, should appear +-- only once in \d output and without the row filter +\d testpub_rf_schema2.testpub_rf_tbl6 + Table "testpub_rf_schema2.testpub_rf_tbl6" + Column | Type | Collation | Nullable | Default +--------+---------+-----------+----------+--------- + i | integer | | | +Included in publications: + "testpub6" + -- fail - virtual generated column uses user-defined function -- (Actually, this already fails at CREATE TABLE rather than at CREATE -- PUBLICATION, but let's keep the test in case the former gets diff --git a/src/test/regress/sql/publication.sql b/src/test/regress/sql/publication.sql index 041e14a4de6..fac54b02e27 100644 --- a/src/test/regress/sql/publication.sql +++ b/src/test/regress/sql/publication.sql @@ -83,6 +83,8 @@ CREATE PUBLICATION testpub_forschema FOR TABLES IN SCHEMA pub_test; CREATE PUBLICATION testpub_for_tbl_schema FOR TABLES IN SCHEMA pub_test, TABLE pub_test.testpub_nopk; RESET client_min_messages; \dRp+ testpub_for_tbl_schema +-- table also covered by a published schema should appear only once in \d output +\d pub_test.testpub_nopk -- weird parser corner case CREATE PUBLICATION testpub_parsertst FOR TABLE pub_test.testpub_nopk, CURRENT_SCHEMA; @@ -406,6 +408,9 @@ CREATE PUBLICATION testpub6 FOR TABLES IN SCHEMA testpub_rf_schema2; ALTER PUBLICATION testpub6 SET TABLES IN SCHEMA testpub_rf_schema2, TABLE testpub_rf_schema2.testpub_rf_tbl6 WHERE (i < 99); RESET client_min_messages; \dRp+ testpub6 +-- table with a row-filter, also covered by a published schema, should appear +-- only once in \d output and without the row filter +\d testpub_rf_schema2.testpub_rf_tbl6 -- fail - virtual generated column uses user-defined function -- (Actually, this already fails at CREATE TABLE rather than at CREATE -- PUBLICATION, but let's keep the test in case the former gets -- 2.54.0