From 4e295d50e250d5e955f9d2ebbe25935858b83a28 Mon Sep 17 00:00:00 2001 From: Peter Smith Date: Wed, 20 May 2026 09:24:57 +1000 Subject: [PATCH v4] Fix psql duplicate items for \dRp+ and \d+ When a publication pub1 is defined using both "TABLES IN SCHEMA myschema", and "TABLE myschema.t1", it caused duplicated items in the psql describe output. This patch simplifies the output and aligns better with the documentation. Now: "\dRp+ pub1" shows only Schema "myschema", not also Table "myschema.t1" "\d+ t1" shows Publication "pub1" only once Author: Peter Smith Co-author: Jim Jones Discussion: https://www.postgresql.org/message-id/flat/CAHut%2BPvSOmRrQX%2BVrFYHtFipV9hM%3Dp99FeOwYCzkuU2BOaLu7Q%40mail.gmail.com --- src/bin/psql/describe.c | 15 +++++++++++++-- src/test/regress/expected/publication.out | 6 ------ 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c index e1449654f96..e326daf632f 100644 --- a/src/bin/psql/describe.c +++ b/src/bin/psql/describe.c @@ -3199,7 +3199,12 @@ describeOneTableDetails(const char *schemaname, "FROM pg_catalog.pg_publication p\n" " JOIN pg_catalog.pg_publication_rel pr ON p.oid = pr.prpubid\n" " JOIN pg_catalog.pg_class c ON c.oid = pr.prrelid\n" - "WHERE pr.prrelid = '%s'\n", + "WHERE pr.prrelid = '%s'\n" + " AND NOT EXISTS (\n" + " SELECT 1\n" + " FROM pg_catalog.pg_publication_namespace pn\n" + " WHERE pn.pnpubid = p.oid\n" + " AND pn.pnnspid = c.relnamespace)\n", oid, oid, oid); if (pset.sversion >= 190000) @@ -7015,7 +7020,13 @@ describePublications(const char *pattern) " pg_catalog.pg_publication_rel pr\n" "WHERE c.relnamespace = n.oid\n" " AND c.oid = pr.prrelid\n" - " AND pr.prpubid = '%s'\n", pubid); + " AND pr.prpubid = '%s'\n" + " AND NOT EXISTS (\n" + " SELECT 1\n" + " FROM pg_catalog.pg_publication_namespace pn\n" + " WHERE pn.pnpubid = pr.prpubid\n" + " AND pn.pnnspid = c.relnamespace)\n", + pubid); if (pset.sversion >= 190000) appendPQExpBufferStr(&buf, " AND NOT pr.prexcept\n"); diff --git a/src/test/regress/expected/publication.out b/src/test/regress/expected/publication.out index 29e54b214a0..b29b6b53119 100644 --- a/src/test/regress/expected/publication.out +++ b/src/test/regress/expected/publication.out @@ -146,8 +146,6 @@ RESET client_min_messages; Owner | All tables | All sequences | Inserts | Updates | Deletes | Truncates | Generated columns | Via root | Description --------------------------+------------+---------------+---------+---------+---------+-----------+-------------------+----------+------------- regress_publication_user | f | f | t | t | t | t | none | f | -Tables: - "pub_test.testpub_nopk" Tables from schemas: "pub_test" @@ -167,8 +165,6 @@ ALTER PUBLICATION testpub_forschema ADD TABLE pub_test.testpub_nopk; Owner | All tables | All sequences | Inserts | Updates | Deletes | Truncates | Generated columns | Via root | Description --------------------------+------------+---------------+---------+---------+---------+-----------+-------------------+----------+------------- regress_publication_user | f | f | t | t | t | t | none | f | -Tables: - "pub_test.testpub_nopk" Tables from schemas: "pub_test" @@ -832,8 +828,6 @@ RESET client_min_messages; Owner | All tables | All sequences | Inserts | Updates | Deletes | Truncates | Generated columns | Via root | Description --------------------------+------------+---------------+---------+---------+---------+-----------+-------------------+----------+------------- regress_publication_user | f | f | t | t | t | t | none | f | -Tables: - "testpub_rf_schema2.testpub_rf_tbl6" WHERE (i < 99) Tables from schemas: "testpub_rf_schema2" -- 2.47.3