From 86e65e16c76fe404cb5a16dd0d89a583da9b62e6 Mon Sep 17 00:00:00 2001 From: "Andrei V. Lepikhov" Date: Wed, 18 Mar 2026 14:23:46 +0100 Subject: [PATCH] Fix self-join removal to update bare Var references in join clauses Self-join removal failed to update Var nodes when the join clause was a bare Var (e.g., ON t1.bool_col) rather than an expression containing Vars. ChangeVarNodesWalkExpression() used expression_tree_walker(), which descends into child nodes but does not process the top-level node itself. When a bare Var referencing the removed relation appeared as the clause, its varno was left unchanged, leading to "no relation entry for relid N" errors. Fix by calling ChangeVarNodes_walker() directly instead of expression_tree_walker(), so the top-level node is also processed. Bug: #19435 Author: Alexander Korotkov Reviewed-by: Tender Wang Reviewed-by: Andrei Lepikhov Reviewed-by: Kirill Reshke Discussion: https://www.postgresql.org/message-id/flat/19435-3cc1a87f291129f1%40postgresql.org --- src/backend/rewrite/rewriteManip.c | 4 +--- src/test/regress/expected/join.out | 16 ++++++++++++++++ src/test/regress/sql/join.sql | 6 ++++++ 3 files changed, 23 insertions(+), 3 deletions(-) diff --git a/src/backend/rewrite/rewriteManip.c b/src/backend/rewrite/rewriteManip.c index fe89754a73c..610edf10284 100644 --- a/src/backend/rewrite/rewriteManip.c +++ b/src/backend/rewrite/rewriteManip.c @@ -744,9 +744,7 @@ ChangeVarNodes(Node *node, int rt_index, int new_index, int sublevels_up) bool ChangeVarNodesWalkExpression(Node *node, ChangeVarNodes_context *context) { - return expression_tree_walker(node, - ChangeVarNodes_walker, - (void *) context); + return ChangeVarNodes_walker(node, context); } /* diff --git a/src/test/regress/expected/join.out b/src/test/regress/expected/join.out index ea3dabff77c..bf758f881ac 100644 --- a/src/test/regress/expected/join.out +++ b/src/test/regress/expected/join.out @@ -8091,6 +8091,22 @@ WHERE q0.a = 1; -> Seq Scan on sj n1 (7 rows) +-- BUG #19435 Do not forget to replace relid in bare Var join clause +ALTER TABLE sl ADD COLUMN cool_bool boolean; +EXPLAIN (COSTS OFF) +SELECT 1 AS c1 FROM sl sl1 LEFT JOIN (sl AS sl2 NATURAL JOIN sl AS sl3) + ON sl2.cool_bool LEFT JOIN sl AS sl4 ON sl2.cool_bool; + QUERY PLAN +--------------------------------------------------------------------------------------------------------------------------- + Nested Loop Left Join + -> Seq Scan on sl sl1 + -> Nested Loop Left Join + Join Filter: sl3.cool_bool + -> Seq Scan on sl sl3 + Filter: (cool_bool AND (a IS NOT NULL) AND (b IS NOT NULL) AND (c IS NOT NULL) AND (cool_bool IS NOT NULL)) + -> Seq Scan on sl sl4 +(7 rows) + -- Check optimization disabling if it will violate special join conditions. -- Two identical joined relations satisfies self join removal conditions but -- stay in different special join infos. diff --git a/src/test/regress/sql/join.sql b/src/test/regress/sql/join.sql index ad90c326c00..faf07f7c4ab 100644 --- a/src/test/regress/sql/join.sql +++ b/src/test/regress/sql/join.sql @@ -3156,6 +3156,12 @@ SELECT * FROM (SELECT n2.a FROM sj n1, sj n2 WHERE n1.a <> n2.a) q0, sl WHERE q0.a = 1; +-- BUG #19435 Do not forget to replace relid in bare Var join clause +ALTER TABLE sl ADD COLUMN cool_bool boolean; +EXPLAIN (COSTS OFF) +SELECT 1 AS c1 FROM sl sl1 LEFT JOIN (sl AS sl2 NATURAL JOIN sl AS sl3) + ON sl2.cool_bool LEFT JOIN sl AS sl4 ON sl2.cool_bool; + -- Check optimization disabling if it will violate special join conditions. -- Two identical joined relations satisfies self join removal conditions but -- stay in different special join infos. -- 2.51.0