From d2eabd283e76aeb1da967581d47b0576a104c28e Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Wed, 14 Jan 2026 13:39:50 -0500 Subject: [PATCH v11 3/7] lwlock: Remove ForEachLWLockHeldByMe As of commit FIXME-XXX-UPDATEME, ForEachLWLockHeldByMe(), introduced in f4ece891fc2f, is not used anymore, as content locks are now implemented in bufmgr.c. It doesn't seem that likely that a new user of the functionality will appear all that soon, making removal of the function seem like the most sensible path. It can easily be added back if necessary. Discussion: https://postgr.es/m/lneuyxqxamqoayd2ntau3lqjblzdckw6tjgeu4574ezwh4tzlg%40noioxkquezdw --- src/include/storage/lwlock.h | 2 -- src/backend/storage/lmgr/lwlock.c | 15 --------------- 2 files changed, 17 deletions(-) diff --git a/src/include/storage/lwlock.h b/src/include/storage/lwlock.h index a98d302c602..df589902adc 100644 --- a/src/include/storage/lwlock.h +++ b/src/include/storage/lwlock.h @@ -129,8 +129,6 @@ extern void LWLockReleaseClearVar(LWLock *lock, pg_atomic_uint64 *valptr, uint64 extern void LWLockReleaseAll(void); extern void LWLockDisown(LWLock *lock); extern void LWLockReleaseDisowned(LWLock *lock, LWLockMode mode); -extern void ForEachLWLockHeldByMe(void (*callback) (LWLock *, LWLockMode, void *), - void *context); extern bool LWLockHeldByMe(LWLock *lock); extern bool LWLockAnyHeldByMe(LWLock *lock, int nlocks, size_t stride); extern bool LWLockHeldByMeInMode(LWLock *lock, LWLockMode mode); diff --git a/src/backend/storage/lmgr/lwlock.c b/src/backend/storage/lmgr/lwlock.c index 415794682a2..2ee0339c52e 100644 --- a/src/backend/storage/lmgr/lwlock.c +++ b/src/backend/storage/lmgr/lwlock.c @@ -1955,21 +1955,6 @@ LWLockReleaseAll(void) } -/* - * ForEachLWLockHeldByMe - run a callback for each held lock - * - * This is meant as debug support only. - */ -void -ForEachLWLockHeldByMe(void (*callback) (LWLock *, LWLockMode, void *), - void *context) -{ - int i; - - for (i = 0; i < num_held_lwlocks; i++) - callback(held_lwlocks[i].lock, held_lwlocks[i].mode, context); -} - /* * LWLockHeldByMe - test whether my process holds a lock in any mode * -- 2.48.1.76.g4e746b1a31.dirty