From 4407d68c4a4b95979e24fc225573944def989fc9 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 13 Oct 2025 16:20:38 -0400 Subject: [PATCH v4 2/4] Add a test case to cover pg_dump with --compress=none. This brings the coverage of compress_none.c up from about 64% to 90%, in particular covering the new code added in the previous patch. This adds perhaps 2% to the runtime of 002_pg_dump.pl. It could be argued that compress_none.c is simple enough to not require permanent memorialization in a test case; but it's less simple than it was before, so maybe we want this. Author: Tom Lane Discussion: https://postgr.es/m/3515357.1760128017@sss.pgh.pa.us --- src/bin/pg_dump/t/002_pg_dump.pl | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/src/bin/pg_dump/t/002_pg_dump.pl b/src/bin/pg_dump/t/002_pg_dump.pl index 6be6888b977..8a08f9a5f6f 100644 --- a/src/bin/pg_dump/t/002_pg_dump.pl +++ b/src/bin/pg_dump/t/002_pg_dump.pl @@ -81,6 +81,24 @@ my %pgdump_runs = ( ], }, + compression_none_custom => { + test_key => 'compression', + dump_cmd => [ + 'pg_dump', + '--format' => 'custom', + '--compress' => 'none', + '--file' => "$tempdir/compression_none_custom.dump", + '--statistics', + 'postgres', + ], + restore_cmd => [ + 'pg_restore', + '--file' => "$tempdir/compression_none_custom.sql", + '--statistics', + "$tempdir/compression_none_custom.dump", + ], + }, + # Do not use --no-sync to give test coverage for data sync. compression_gzip_custom => { test_key => 'compression', -- 2.43.7