From 7ea0c526f41fcc30951f1a25acaedb65f340eeed Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Thu, 7 Aug 2025 15:58:34 +0200 Subject: [PATCH 3/4] headerscheck: Ignore Windows-specific header Ignore src/include/port/win32/sys/resource.h. At least on macOS, including this results in warnings and errors because of duplication with system headers: ../src/include/port/win32/sys/resource.h:10:9: warning: 'RUSAGE_CHILDREN' redefined ../src/include/port/win32/sys/resource.h:16:1: error: redefinition of struct or union 'struct rusage' Since we are also not checking similar system-replacement headers for Windows, it makes sense to exclude this one, too. --- src/tools/pginclude/headerscheck | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/pginclude/headerscheck b/src/tools/pginclude/headerscheck index e984a441edb..850bf293ae5 100755 --- a/src/tools/pginclude/headerscheck +++ b/src/tools/pginclude/headerscheck @@ -98,7 +98,7 @@ do # Additional Windows-specific headers. test "$f" = src/include/port/win32_port.h && continue test "$f" = src/include/port/win32/netdb.h && continue - $cplusplus && test "$f" = src/include/port/win32/sys/resource.h && continue + test "$f" = src/include/port/win32/sys/resource.h && continue test "$f" = src/include/port/win32/sys/socket.h && continue test "$f" = src/include/port/win32_msvc/dirent.h && continue test "$f" = src/include/port/win32_msvc/utime.h && continue -- 2.50.1