From 7c9146f221a253aa3a150f6b6d5600ed0225e4e1 Mon Sep 17 00:00:00 2001 From: Yugo Nagata Date: Thu, 5 Jun 2025 15:32:37 +0900 Subject: [PATCH v7 3/4] Improve error reporting for concurrent updates on system catalog tuples Previously, when multiple sessions attempted to modify the same system catalog tuple concurrently due to insufficient locking, DDL commands could fail with an internal error: ERROR: tuple concurrently updated This commit improves the behavior by reporting a more appropriate and user-facing error message in such cases, making it easier for users to understand the cause of the failure. --- src/backend/access/heap/heapam.c | 34 ++++++++++++++++--- .../expected/syscache-update-pruned.out | 2 +- 2 files changed, 31 insertions(+), 5 deletions(-) diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c index 0dcd6ee817e..712b7ded6d2 100644 --- a/src/backend/access/heap/heapam.c +++ b/src/backend/access/heap/heapam.c @@ -3194,6 +3194,7 @@ simple_heap_delete(Relation relation, ItemPointer tid) { TM_Result result; TM_FailureData tmfd; + bool is_catalog = IsCatalogRelation(relation); result = heap_delete(relation, tid, GetCurrentCommandId(true), InvalidSnapshot, @@ -3211,11 +3212,23 @@ simple_heap_delete(Relation relation, ItemPointer tid) break; case TM_Updated: - elog(ERROR, "tuple concurrently updated"); + if (is_catalog) + ereport(ERROR, + (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE), + errmsg("operation failed due to a concurrent command"), + errdetail("Another command modified the same object in a concurrent session."))); + else + elog(ERROR, "tuple concurrently updated"); break; case TM_Deleted: - elog(ERROR, "tuple concurrently deleted"); + if (is_catalog) + ereport(ERROR, + (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE), + errmsg("operation failed due to a concurrent command"), + errdetail("Another command dropped the same object in a concurrent session."))); + else + elog(ERROR, "tuple concurrently deleted"); break; default: @@ -4486,6 +4499,7 @@ simple_heap_update(Relation relation, ItemPointer otid, HeapTuple tup, TM_Result result; TM_FailureData tmfd; LockTupleMode lockmode; + bool is_catalog = IsCatalogRelation(relation); result = heap_update(relation, otid, tup, GetCurrentCommandId(true), InvalidSnapshot, @@ -4503,11 +4517,23 @@ simple_heap_update(Relation relation, ItemPointer otid, HeapTuple tup, break; case TM_Updated: - elog(ERROR, "tuple concurrently updated"); + if (is_catalog) + ereport(ERROR, + (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE), + errmsg("operation failed due to a concurrent command"), + errdetail("Another command modified the same object in a concurrent session."))); + else + elog(ERROR, "tuple concurrently updated"); break; case TM_Deleted: - elog(ERROR, "tuple concurrently deleted"); + if (is_catalog) + ereport(ERROR, + (errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE), + errmsg("operation failed due to a concurrent command"), + errdetail("Another command dropped the same object in a concurrent session."))); + else + elog(ERROR, "tuple concurrently deleted"); break; default: diff --git a/src/test/modules/injection_points/expected/syscache-update-pruned.out b/src/test/modules/injection_points/expected/syscache-update-pruned.out index a6a4e8db996..231545a6cbb 100644 --- a/src/test/modules/injection_points/expected/syscache-update-pruned.out +++ b/src/test/modules/injection_points/expected/syscache-update-pruned.out @@ -20,7 +20,7 @@ step wakegrant4: SELECT FROM injection_points_wakeup('heap_update-before-pin'); step grant1: <... completed> -ERROR: tuple concurrently deleted +ERROR: operation failed due to a concurrent command step wakegrant4: <... completed> starting permutation: cachefill1 at2 waitprunable4 vac4 grant1 wakeinval4 mkrels4 wakegrant4 -- 2.43.0