From 696292df195631b64b3724cb93c0e5d32b14b659 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut <peter@eisentraut.org>
Date: Wed, 18 Jun 2025 10:18:26 +0200
Subject: [PATCH 2/5] ci: Run meson with --fatal-meson-warnings

To quote from the meson commit log:

> This makes any warning message printed by meson raise an exception,
> intended to be used by CI and developpers to easily catch deprecation
> warnings and other potential issues.

But not for the Windows VS task, because that currently produces

    WARNING: Using a debug build type with MSVC or an MSVC-compatible compiler
    when the Python interpreter is not also a debug build will almost
    certainly result in a failed build. Prefer using a release build
    type or a debug Python interpreter.

That should maybe be fixed separately.
---
 .cirrus.tasks.yml | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/.cirrus.tasks.yml b/.cirrus.tasks.yml
index 92057006c93..0650263d58c 100644
--- a/.cirrus.tasks.yml
+++ b/.cirrus.tasks.yml
@@ -105,6 +105,7 @@ task:
   configure_script: |
     su postgres <<-EOF
       meson setup \
+        --fatal-meson-warnings \
         --buildtype=debug \
         --auto-features=disabled \
         -Dtap_tests=enabled \
@@ -196,6 +197,7 @@ task:
   configure_script: |
     su postgres <<-EOF
       meson setup \
+        --fatal-meson-warnings \
         --buildtype=debug \
         -Dcassert=true -Dinjection_points=true \
         -Duuid=bsd -Dtcl_version=tcl86 -Ddtrace=auto \
@@ -314,6 +316,7 @@ task:
   configure_script: |
     su postgres <<-EOF
       meson setup \
+        --fatal-meson-warnings \
         --buildtype=debugoptimized \
         --pkg-config-path ${PKGCONFIG_PATH} \
         -Dcassert=true -Dinjection_points=true \
@@ -506,6 +509,7 @@ task:
       configure_script: |
         su postgres <<-EOF
           meson setup \
+            --fatal-meson-warnings \
             --buildtype=debug \
             -Dcassert=true -Dinjection_points=true \
             ${LINUX_MESON_FEATURES} \
@@ -518,6 +522,7 @@ task:
         su postgres <<-EOF
           export CC='ccache gcc -m32'
           meson setup \
+            --fatal-meson-warnings \
             --buildtype=debug \
             -Dcassert=true -Dinjection_points=true \
             ${LINUX_MESON_FEATURES} \
@@ -657,6 +662,7 @@ task:
   configure_script: |
     export PKG_CONFIG_PATH="/opt/local/lib/pkgconfig/"
     meson setup \
+      --fatal-meson-warnings \
       --buildtype=debug \
       -Dextra_include_dirs=/opt/local/include \
       -Dextra_lib_dirs=/opt/local/lib \
@@ -793,7 +799,7 @@ task:
 
   # disable -Dnls as the number of files it creates cause a noticable slowdown
   configure_script: |
-    %BASH% -c "meson setup -Ddebug=true -Doptimization=g -Dcassert=true -Dinjection_points=true -Db_pch=true -Dnls=disabled -DTAR=%TAR% build"
+    %BASH% -c "meson setup --fatal-meson-warnings -Ddebug=true -Doptimization=g -Dcassert=true -Dinjection_points=true -Db_pch=true -Dnls=disabled -DTAR=%TAR% build"
 
   build_script: |
     %BASH% -c "ninja -C build ${MBUILD_TARGET}"
-- 
2.49.0