From f345f5dbbd0324a1b7389e046caefecab4c357fc Mon Sep 17 00:00:00 2001 From: Ashutosh Bapat Date: Fri, 13 Sep 2024 10:58:40 +0530 Subject: [PATCH 3/4] Improve comment about configuration time PG_TEST_EXTRA The comment mentioned "not safe" and "while-space separate list" which are not relevant to the code in meson.build file. The purpose mentioned in the comment has already gone stale; the variable is used for tests which take longer but are otherwise safe. And the content may change in the future. This code should just make the value of the variable available to the tests irrespective of its purpose and content. Improved the comment to mention how the PG_TEST_EXTRA is passed to tests instead of the variable's content and purpose. Ashutosh Bapat --- meson.build | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/meson.build b/meson.build index 9d1d8847af3..24a25a72bd1 100644 --- a/meson.build +++ b/meson.build @@ -3385,11 +3385,10 @@ foreach test_dir : tests testwrap, '--basedir', meson.build_root(), '--srcdir', test_dir['sd'], - # Test suites that are not safe by default but can be run if selected - # by the user via the whitespace-separated list in variable PG_TEST_EXTRA. - # Export PG_TEST_EXTRA so it can be checked in individual tap tests. - # This configure option is overridden by PG_TEST_EXTRA environment variable - # if it exists. + # Some test suites are not run by default but can be run if selected by the + # user via variable PG_TEST_EXTRA. Pass configuration time value of + # PG_TEST_EXTRA as an argument to testwrap so that it can be overridden by + # run time value, if any. '--pg-test-extra', get_option('PG_TEST_EXTRA'), ] -- 2.34.1