From fb33b7eb5482bae31b70bb54dbe77325b543a89c Mon Sep 17 00:00:00 2001 From: Thomas Munro Date: Mon, 20 Nov 2023 14:24:35 +1300 Subject: [PATCH v5 1/2] MinGW has GetLocaleInfoEx(). To use BCP 47 locale names like "en-US" without a suffix ".encoding", we need to be able to call GetLocaleInfoEx() to look up the encoding. That was previously gated for MSVC only, but MinGW has had the function for many years. Remove that gating, because otherwise our MinGW build farm animals would fail when a later commit switches to using the new names by default. There are probably other places where _MSC_VER is being used as a proxy for detecting MinGW with an out-of-date idea about missing functions. Discussion: https://postgr.es/m/CA%2BhUKGLsV3vTjPp7bOZBr3JTKp3Brkr9V0Qfmc7UvpWcmAQL4A%40mail.gmail.com --- src/port/chklocale.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/port/chklocale.c b/src/port/chklocale.c index 8cb81c8640e..a15b0d5349b 100644 --- a/src/port/chklocale.c +++ b/src/port/chklocale.c @@ -204,7 +204,6 @@ win32_langinfo(const char *ctype) char *r = NULL; char *codepage; -#if defined(_MSC_VER) uint32 cp; WCHAR wctype[LOCALE_NAME_MAX_LENGTH]; @@ -229,7 +228,6 @@ win32_langinfo(const char *ctype) } } else -#endif { /* * Locale format on Win32 is _.. For -- 2.45.2