From cd32de9ec14dba0011f8c05e6a8ab7e4f7be045c Mon Sep 17 00:00:00 2001 From: Mikhail Litsarev Date: Thu, 13 Jun 2024 18:47:47 +0300 Subject: [PATCH] Tests for standby-is-requested mode. Add tiny tests in src/test/recovery/t/004_timeline_switch.pl They validate: - master is not a replica - standby_1 is a replica - promoted replica in master mode - standby_2 remains a replica after switch to promoted master --- src/test/recovery/t/004_timeline_switch.pl | 25 ++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/src/test/recovery/t/004_timeline_switch.pl b/src/test/recovery/t/004_timeline_switch.pl index 684838cbab7..11f0b22ae90 100644 --- a/src/test/recovery/t/004_timeline_switch.pl +++ b/src/test/recovery/t/004_timeline_switch.pl @@ -16,6 +16,11 @@ my $node_primary = PostgreSQL::Test::Cluster->new('primary'); $node_primary->init(allows_streaming => 1); $node_primary->start; +# Validate pg_get_recovery_flags() for master +my $ret_mode_primary = $node_primary->safe_psql('postgres', + 'SELECT pg_get_recovery_flags()'); +is($ret_mode_primary, '{}', "master is not a replica"); + # Take backup my $backup_name = 'my_backup'; $node_primary->backup($backup_name); @@ -30,6 +35,12 @@ $node_standby_2->init_from_backup($node_primary, $backup_name, has_streaming => 1); $node_standby_2->start; +# Validate standby-mode-requested state for replica node +my $ret_mode_standby_1 = $node_standby_1->safe_psql('postgres', + 'SELECT pg_get_recovery_flags()'); +is($ret_mode_standby_1, '{STANDBY_MODE_REQUESTED}', "node_standby_1 is a replica"); +print($ret_mode_standby_1); + # Create some content on primary $node_primary->safe_psql('postgres', "CREATE TABLE tab_int AS SELECT generate_series(1,1000) AS a"); @@ -48,6 +59,15 @@ $node_standby_1->psql( stdout => \$psql_out); is($psql_out, 't', "promotion of standby with pg_promote"); +# Validate pg_get_recovery_flags() for master promoted from standby node. +# STANDBY_MODE_REQUESTED is returned because standby.signal file +# was found while being a replica. +# Use it with pg_is_in_recovery() (will return false), for such use-cases. +my $ret_mode_1 = $node_standby_1->safe_psql('postgres', + 'SELECT pg_get_recovery_flags()'); +is($ret_mode_1, '{PROMOTE_IS_TRIGGERED,STANDBY_MODE_REQUESTED}', + "node_standby_1 becomes a master"); + # Switch standby 2 to replay from standby 1 my $connstr_1 = $node_standby_1->connstr; $node_standby_2->append_conf( @@ -56,6 +76,11 @@ primary_conninfo='$connstr_1' )); $node_standby_2->restart; +# Validate STANDBY_MODE_REQUESTED for second replica after restart +my $ret_mode_standby_2 = $node_standby_2->safe_psql('postgres', + 'SELECT pg_get_recovery_flags()'); +is($ret_mode_standby_2, '{STANDBY_MODE_REQUESTED}', "node_standby_2 remains a replica"); + # Insert some data in standby 1 and check its presence in standby 2 # to ensure that the timeline switch has been done. $node_standby_1->safe_psql('postgres', -- 2.34.1