From 8938017869025598024f0aba950c0aeccbcbe651 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Sat, 23 Dec 2023 14:25:26 +0100 Subject: [PATCH v2 1/3] pg_stat_statements: Exclude from lcov functions that are impossible to test The current code only supports installing version 1.4 of pg_stat_statements and upgrading from there. So the C code entry points for older versions are not reachable from the tests. To prevent this from ruining the test coverage figures, mark those functions are excluded from lcov. Discussion: https://www.postgresql.org/message-id/flat/40d1e4f2-835f-448f-a541-8ff5db75bf3d@eisentraut.org --- contrib/pg_stat_statements/pg_stat_statements.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/contrib/pg_stat_statements/pg_stat_statements.c b/contrib/pg_stat_statements/pg_stat_statements.c index 6f62a531f7..8ac73bf55e 100644 --- a/contrib/pg_stat_statements/pg_stat_statements.c +++ b/contrib/pg_stat_statements/pg_stat_statements.c @@ -311,13 +311,15 @@ static bool pgss_save = true; /* whether to save stats across shutdown */ PG_FUNCTION_INFO_V1(pg_stat_statements_reset); PG_FUNCTION_INFO_V1(pg_stat_statements_reset_1_7); PG_FUNCTION_INFO_V1(pg_stat_statements_reset_1_11); +/* LCOV_EXCL_START */ +PG_FUNCTION_INFO_V1(pg_stat_statements); PG_FUNCTION_INFO_V1(pg_stat_statements_1_2); +/* LCOV_EXCL_STOP */ PG_FUNCTION_INFO_V1(pg_stat_statements_1_3); PG_FUNCTION_INFO_V1(pg_stat_statements_1_8); PG_FUNCTION_INFO_V1(pg_stat_statements_1_9); PG_FUNCTION_INFO_V1(pg_stat_statements_1_10); PG_FUNCTION_INFO_V1(pg_stat_statements_1_11); -PG_FUNCTION_INFO_V1(pg_stat_statements); PG_FUNCTION_INFO_V1(pg_stat_statements_info); static void pgss_shmem_request(void); @@ -1610,6 +1612,8 @@ pg_stat_statements_1_3(PG_FUNCTION_ARGS) return (Datum) 0; } +/* LCOV_EXCL_START */ + Datum pg_stat_statements_1_2(PG_FUNCTION_ARGS) { @@ -1633,6 +1637,8 @@ pg_stat_statements(PG_FUNCTION_ARGS) return (Datum) 0; } +/* LCOV_EXCL_STOP */ + /* Common code for all versions of pg_stat_statements() */ static void pg_stat_statements_internal(FunctionCallInfo fcinfo, base-commit: 7e6fb5da41d8ee1bddcd5058b7204018ef68d193 -- 2.43.0