From 1033183cea71c6bd37934cedb972d35a4e251134 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Sat, 23 Dec 2023 14:25:26 +0100 Subject: [PATCH v1 2/5] pg_stat_statements: Add coverage for pg_stat_statements_1_8() This requires reading pg_stat_statements at least once while the 1.8 version of the extension is installed. --- .../expected/oldextversions.out | 24 ++++++++++++------- .../pg_stat_statements/sql/oldextversions.sql | 3 ++- 2 files changed, 17 insertions(+), 10 deletions(-) diff --git a/contrib/pg_stat_statements/expected/oldextversions.out b/contrib/pg_stat_statements/expected/oldextversions.out index ec317b0d6b..f3a90cac0a 100644 --- a/contrib/pg_stat_statements/expected/oldextversions.out +++ b/contrib/pg_stat_statements/expected/oldextversions.out @@ -88,6 +88,17 @@ SELECT count(*) > 0 AS has_data FROM pg_stat_statements; -- New functions and views for pg_stat_statements in 1.8 AlTER EXTENSION pg_stat_statements UPDATE TO '1.8'; +SELECT pg_get_functiondef('pg_stat_statements_reset'::regproc); + pg_get_functiondef +-------------------------------------------------------------------------------------------------------------------------------- + CREATE OR REPLACE FUNCTION public.pg_stat_statements_reset(userid oid DEFAULT 0, dbid oid DEFAULT 0, queryid bigint DEFAULT 0)+ + RETURNS void + + LANGUAGE c + + PARALLEL SAFE STRICT + + AS '$libdir/pg_stat_statements', $function$pg_stat_statements_reset_1_7$function$ + + +(1 row) + \d pg_stat_statements View "public.pg_stat_statements" Column | Type | Collation | Nullable | Default @@ -125,15 +136,10 @@ AlTER EXTENSION pg_stat_statements UPDATE TO '1.8'; wal_fpi | bigint | | | wal_bytes | numeric | | | -SELECT pg_get_functiondef('pg_stat_statements_reset'::regproc); - pg_get_functiondef --------------------------------------------------------------------------------------------------------------------------------- - CREATE OR REPLACE FUNCTION public.pg_stat_statements_reset(userid oid DEFAULT 0, dbid oid DEFAULT 0, queryid bigint DEFAULT 0)+ - RETURNS void + - LANGUAGE c + - PARALLEL SAFE STRICT + - AS '$libdir/pg_stat_statements', $function$pg_stat_statements_reset_1_7$function$ + - +SELECT count(*) > 0 AS has_data FROM pg_stat_statements; + has_data +---------- + t (1 row) -- New function pg_stat_statement_info, and new function diff --git a/contrib/pg_stat_statements/sql/oldextversions.sql b/contrib/pg_stat_statements/sql/oldextversions.sql index ec06caa5dd..5cf515f6b0 100644 --- a/contrib/pg_stat_statements/sql/oldextversions.sql +++ b/contrib/pg_stat_statements/sql/oldextversions.sql @@ -33,8 +33,9 @@ CREATE EXTENSION pg_stat_statements WITH VERSION '1.4'; -- New functions and views for pg_stat_statements in 1.8 AlTER EXTENSION pg_stat_statements UPDATE TO '1.8'; -\d pg_stat_statements SELECT pg_get_functiondef('pg_stat_statements_reset'::regproc); +\d pg_stat_statements +SELECT count(*) > 0 AS has_data FROM pg_stat_statements; -- New function pg_stat_statement_info, and new function -- and view for pg_stat_statements introduced in 1.9 -- 2.43.0