From 62ae12c486b4c33ed92ad458d1466e62605be583 Mon Sep 17 00:00:00 2001 From: Melanie Plageman Date: Wed, 8 Nov 2023 13:47:48 -0500 Subject: [PATCH v1 2/9] Rename frozen_pages to pages_frozen for clarity LVRelState counts the number of pages frozen during a vacuum of a relation. Newly frozen pages may not stay frozen, so rename this member to clarify that it is the number of pages which were frozen, not the number of pages that are frozen. --- src/backend/access/heap/vacuumlazy.c | 8 ++++---- src/include/commands/vacuum.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/backend/access/heap/vacuumlazy.c b/src/backend/access/heap/vacuumlazy.c index 0b86c9d4ea..9409cf6b38 100644 --- a/src/backend/access/heap/vacuumlazy.c +++ b/src/backend/access/heap/vacuumlazy.c @@ -335,7 +335,7 @@ heap_vacuum_rel(Relation rel, VacuumParams *params, /* Initialize page counters explicitly (be tidy) */ vacrel->scanned_pages = 0; vacrel->removed_pages = 0; - vacrel->frozen_pages = 0; + vacrel->pages_frozen = 0; vacrel->lpdead_item_pages = 0; vacrel->missed_dead_pages = 0; vacrel->nonempty_pages = 0; @@ -601,9 +601,9 @@ heap_vacuum_rel(Relation rel, VacuumParams *params, vacrel->NewRelminMxid, diff); } appendStringInfo(&buf, _("frozen: %u pages from table (%.2f%% of total) had %lld tuples frozen\n"), - vacrel->frozen_pages, + vacrel->pages_frozen, orig_rel_pages == 0 ? 100.0 : - 100.0 * vacrel->frozen_pages / orig_rel_pages, + 100.0 * vacrel->pages_frozen / orig_rel_pages, (long long) vacrel->tuples_frozen); if (vacrel->do_index_vacuuming) { @@ -1712,7 +1712,7 @@ lazy_scan_prune(LVRelState *vacrel, { TransactionId snapshotConflictHorizon; - vacrel->frozen_pages++; + vacrel->pages_frozen++; /* * We can use visibility_cutoff_xid as our cutoff for conflicts diff --git a/src/include/commands/vacuum.h b/src/include/commands/vacuum.h index f48c4ab95a..fa91e1b465 100644 --- a/src/include/commands/vacuum.h +++ b/src/include/commands/vacuum.h @@ -356,7 +356,7 @@ typedef struct LVRelState BlockNumber rel_pages; /* total number of pages */ BlockNumber scanned_pages; /* # pages examined (not skipped via VM) */ BlockNumber removed_pages; /* # pages removed by relation truncation */ - BlockNumber frozen_pages; /* # pages with newly frozen tuples */ + BlockNumber pages_frozen; /* # pages with newly frozen tuples */ BlockNumber lpdead_item_pages; /* # pages with LP_DEAD items */ BlockNumber missed_dead_pages; /* # pages with missed dead tuples */ BlockNumber nonempty_pages; /* actually, last nonempty page + 1 */ -- 2.37.2