From 4e95c8fc73c49da8f38ee18439280c1269163c60 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Wed, 1 Mar 2023 09:52:26 +0100 Subject: [PATCH v1 3/3] doc: Remove subfeatures from SQL features listing Non-optional subfeatures have been removed from SQL:2023. The remaining mandatory subfeature specifications are poorly defined and not very interesting. By removing them we can save some complexity in the tooling and the final presentation. TODO: Remove the columns for the subfeatures in src/backend/catalog/sql_features.txt. --- doc/src/sgml/features.sgml | 8 -- doc/src/sgml/mk_feature_tables.pl | 22 +---- src/backend/catalog/sql_features.txt | 141 --------------------------- 3 files changed, 4 insertions(+), 167 deletions(-) diff --git a/doc/src/sgml/features.sgml b/doc/src/sgml/features.sgml index 575afa3476..44611e0509 100644 --- a/doc/src/sgml/features.sgml +++ b/doc/src/sgml/features.sgml @@ -98,14 +98,6 @@ SQL Conformance information about what does and does not work. - - - Feature codes containing a hyphen are subfeatures. Therefore, if a - particular subfeature is not supported, the main feature is listed - as unsupported even if some other subfeatures are supported. - - - Supported Features diff --git a/doc/src/sgml/mk_feature_tables.pl b/doc/src/sgml/mk_feature_tables.pl index 5a16da0d06..f519935f74 100644 --- a/doc/src/sgml/mk_feature_tables.pl +++ b/doc/src/sgml/mk_feature_tables.pl @@ -37,36 +37,22 @@ my ($feature_id, $feature_name, $subfeature_id, $subfeature_name, $is_supported, $comments) = split /\t/; + die if $subfeature_id; # XXX + $is_supported eq $yesno || next; $feature_name =~ s//>/g; - $subfeature_name =~ s//>/g; print " \n"; - if ($subfeature_id) - { - print " $feature_id-$subfeature_id\n"; - } - else - { - print " $feature_id\n"; - } + print " $feature_id\n"; print " ", defined($feature_packages{$feature_id}) ? $feature_packages{$feature_id} : "", "\n"; - if ($subfeature_id) - { - print " $subfeature_name\n"; - } - else - { - print " $feature_name\n"; - } + print " $feature_name\n"; print " $comments\n"; print " \n"; diff --git a/src/backend/catalog/sql_features.txt b/src/backend/catalog/sql_features.txt index fc5c2a20bd..03ae11fc64 100644 --- a/src/backend/catalog/sql_features.txt +++ b/src/backend/catalog/sql_features.txt @@ -43,127 +43,26 @@ B209 PTF extended names NO B211 Module language Ada: VARCHAR and NUMERIC support NO B221 Routine language Ada: VARCHAR and NUMERIC support NO E011 Numeric data types YES -E011 Numeric data types 01 INTEGER and SMALLINT data types YES -E011 Numeric data types 02 REAL, DOUBLE PRECISION, and FLOAT data types YES -E011 Numeric data types 03 DECIMAL and NUMERIC data types YES -E011 Numeric data types 04 Arithmetic operators YES -E011 Numeric data types 05 Numeric comparison YES -E011 Numeric data types 06 Implicit casting among the numeric data types YES E021 Character data types YES -E021 Character string types 01 CHARACTER data type YES -E021 Character string types 02 CHARACTER VARYING data type YES -E021 Character string types 03 Character literals YES -E021 Character string types 04 CHARACTER_LENGTH function YES trims trailing spaces from CHARACTER values before counting -E021 Character string types 05 OCTET_LENGTH function YES -E021 Character string types 06 SUBSTRING function YES -E021 Character string types 07 Character concatenation YES -E021 Character string types 08 UPPER and LOWER functions YES -E021 Character string types 09 TRIM function YES -E021 Character string types 10 Implicit casting among the character string types YES -E021 Character string types 11 POSITION function YES -E021 Character string types 12 Character comparison YES E031 Identifiers YES -E031 Identifiers 01 Delimited identifiers YES -E031 Identifiers 02 Lower case identifiers YES -E031 Identifiers 03 Trailing underscore YES E051 Basic query specification YES -E051 Basic query specification 01 SELECT DISTINCT YES -E051 Basic query specification 02 GROUP BY clause YES -E051 Basic query specification 04 GROUP BY can contain columns not in