commit d80742fbe2124687591e76dc069d7cab6a2cecc8 Author: Jacob Champion Date: Fri Apr 2 10:31:40 2021 -0700 squash! Plug more TAP test suites with new PostgresNode's new routines diff --git a/src/test/kerberos/t/001_auth.pl b/src/test/kerberos/t/001_auth.pl index 31fdc49b86..2395664145 100644 --- a/src/test/kerberos/t/001_auth.pl +++ b/src/test/kerberos/t/001_auth.pl @@ -20,7 +20,7 @@ use Time::HiRes qw(usleep); if ($ENV{with_gssapi} eq 'yes') { - plan tests => 30; + plan tests => 34; } else { @@ -192,7 +192,7 @@ sub test_access { # The result is assumed to match "true", or "t", here. $node->connect_ok($connstr, $test_name, sql => $query, - expected_stdout => qr/t/); + expected_stdout => qr/^t$/); } else { @@ -223,9 +223,9 @@ sub test_query my $connstr = $node->connstr('postgres') . " user=$role host=$host hostaddr=$hostaddr $gssencmode"; - my ($stdoutres, $stderrres); - - $node->connect_ok($connstr, $test_name, $query, $expected); + $node->connect_ok($connstr, $test_name, sql => $query, + expected_stdout => $expected, + expected_stderr => qr/^$/); return; } diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm index ba1407e761..f29c877c79 100644 --- a/src/test/perl/PostgresNode.pm +++ b/src/test/perl/PostgresNode.pm @@ -1876,6 +1876,10 @@ instead of the default. If this regular expression is set, matches it with the output generated. +=item expected_stderr => B + +If this regular expression is set, matches it with the stderr generated. + =back =cut @@ -1906,7 +1910,11 @@ sub connect_ok if (defined($params{expected_stdout})) { - like($stdout, $params{expected_stdout}, "$test_name: matches"); + like($stdout, $params{expected_stdout}, "$test_name: stdout matches"); + } + if (defined($params{expected_stderr})) + { + like($stderr, $params{expected_stderr}, "$test_name: stderr matches"); } } diff --git a/src/test/ssl/t/001_ssltests.pl b/src/test/ssl/t/001_ssltests.pl index 21beef01aa..6df558fca7 100644 --- a/src/test/ssl/t/001_ssltests.pl +++ b/src/test/ssl/t/001_ssltests.pl @@ -446,15 +446,15 @@ TODO: # correct client cert in encrypted PEM with empty password $node->connect_fails( "$common_connstr user=ssltestuser sslcert=ssl/client.crt sslkey=ssl/client-encrypted-pem_tmp.key sslpassword=''", - expected_stderr => qr!\Qprivate key file "ssl/client-encrypted-pem_tmp.key": processing error\E!, - "certificate authorization fails with correct client cert and empty password in encrypted PEM format" + "certificate authorization fails with correct client cert and empty password in encrypted PEM format", + expected_stderr => qr!\Qprivate key file "ssl/client-encrypted-pem_tmp.key": processing error\E! ); # correct client cert in encrypted PEM with no password $node->connect_fails( "$common_connstr user=ssltestuser sslcert=ssl/client.crt sslkey=ssl/client-encrypted-pem_tmp.key", - expected_stderr => qr!\Qprivate key file "ssl/client-encrypted-pem_tmp.key": processing error\E!, - "certificate authorization fails with correct client cert and no password in encrypted PEM format" + "certificate authorization fails with correct client cert and no password in encrypted PEM format", + expected_stderr => qr!\Qprivate key file "ssl/client-encrypted-pem_tmp.key": processing error\E! ); }