From f235a691722a464059358cd6b1d744f75d7bf92f Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Sun, 2 Feb 2020 09:49:57 -0600 Subject: [PATCH v1] preserve CLUSTER ON during ALTER TABLE --- src/backend/commands/tablecmds.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index f599393..c4e6cbd 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -11616,6 +11616,7 @@ RememberIndexForRebuilding(Oid indoid, AlteredTableInfo *tab) } else { + Relation indrel; /* OK, capture the index's existing definition string */ char *defstring = pg_get_indexdef_string(indoid); @@ -11623,6 +11624,18 @@ RememberIndexForRebuilding(Oid indoid, AlteredTableInfo *tab) indoid); tab->changedIndexDefs = lappend(tab->changedIndexDefs, defstring); + /* Preserve CLUSTER ON if set */ + indrel = index_open(indoid, AccessShareLock); + if (indrel->rd_index->indisclustered) { + char buf[3*NAMEDATALEN + 24]; + sprintf(buf, "ALTER TABLE %s CLUSTER ON %s", + get_rel_name(tab->relid), get_rel_name(indoid)); // XXX: schema + tab->changedIndexOids = lappend_oid(tab->changedIndexOids, + indoid); + tab->changedIndexDefs = lappend(tab->changedIndexDefs, + pstrdup(buf)); + } + index_close(indrel, NoLock); } } } @@ -11901,6 +11914,11 @@ ATPostAlterTypeParse(Oid oldId, Oid oldRelId, Oid refRelId, char *cmd, * the new table definition. */ } + else if (cmd->subtype == AT_ClusterOn) + { + tab->subcmds[AT_PASS_OLD_INDEX] = + lappend(tab->subcmds[AT_PASS_OLD_INDEX], cmd); + } else elog(ERROR, "unexpected statement subtype: %d", (int) cmd->subtype); -- 2.7.4