From e258d242fc0ef653aa7654af6fb065c7133ba430 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Tue, 23 Jul 2019 17:48:18 -0400 Subject: [PATCH v3] Don't uselessly escape a string that doesn't need escaping Per gripe from Ian Barwick Discussion: https://postgr.es/m/CABvVfJWNnNKb8cHsTLhkTsvL1+G6BVcV+57+w1JZ61p8YGPdWQ@mail.gmail.com --- src/bin/pg_basebackup/pg_basebackup.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c index 77a7c148ba..e7755e807d 100644 --- a/src/bin/pg_basebackup/pg_basebackup.c +++ b/src/bin/pg_basebackup/pg_basebackup.c @@ -1715,11 +1715,9 @@ GenerateRecoveryConf(PGconn *conn) free(escaped); if (replication_slot) - { - escaped = escape_quotes(replication_slot); - appendPQExpBuffer(recoveryconfcontents, "primary_slot_name = '%s'\n", replication_slot); - free(escaped); - } + /* unescaped: ReplicationSlotValidateName allows [a-z0-9_] only */ + appendPQExpBuffer(recoveryconfcontents, "primary_slot_name = '%s'\n", + replication_slot); if (PQExpBufferBroken(recoveryconfcontents) || PQExpBufferDataBroken(conninfo_buf)) -- 2.17.1