From a66fbef1fc05bd4d5907851bf93c4e268cd477ab Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 11 Jun 2019 16:40:41 +0200 Subject: [PATCH v1 2/4] Fix comment The last argument of smgrextend() was renamed from isTemp to skipFsync in debcec7dc31a992703911a9953e299c8d730c778, but the comments at two call sites were not updated. --- src/backend/access/heap/rewriteheap.c | 7 +++---- src/backend/catalog/storage.c | 6 +++--- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/backend/access/heap/rewriteheap.c b/src/backend/access/heap/rewriteheap.c index 369694fa2e..916231e2c4 100644 --- a/src/backend/access/heap/rewriteheap.c +++ b/src/backend/access/heap/rewriteheap.c @@ -703,10 +703,9 @@ raw_heap_insert(RewriteState state, HeapTuple tup) true); /* - * Now write the page. We say isTemp = true even if it's not a - * temp table, because there's no need for smgr to schedule an - * fsync for this write; we'll do it ourselves in - * end_heap_rewrite. + * Now write the page. We say skipFsync = true because there's no + * need for smgr to schedule an fsync for this write; we'll do it + * ourselves in end_heap_rewrite. */ RelationOpenSmgr(state->rs_new_rel); diff --git a/src/backend/catalog/storage.c b/src/backend/catalog/storage.c index 3cc886f7fe..d6112fa535 100644 --- a/src/backend/catalog/storage.c +++ b/src/backend/catalog/storage.c @@ -358,9 +358,9 @@ RelationCopyStorage(SMgrRelation src, SMgrRelation dst, PageSetChecksumInplace(page, blkno); /* - * Now write the page. We say isTemp = true even if it's not a temp - * rel, because there's no need for smgr to schedule an fsync for this - * write; we'll do it ourselves below. + * Now write the page. We say skipFsync = true because there's no + * need for smgr to schedule an fsync for this write; we'll do it + * ourselves below. */ smgrextend(dst, forkNum, blkno, buf.data, true); } -- 2.22.0