From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Fix case of window function + aggregate + GROUP BY expression. |
Date: | 2012-09-13 15:32:53 |
Message-ID: | E1TCBPR-0003Y8-OL@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix case of window function + aggregate + GROUP BY expression.
In commit 1bc16a946008a7cbb33a9a06a7c6765a807d7f59 I added a minor
optimization to drop the component variables of a GROUP BY expression from
the target list computed at the aggregation level of a query, if those Vars
weren't referenced elsewhere in the tlist. However, I overlooked that the
window-function planning code would deconstruct such expressions and thus
need to have access to their component variables. Fix it to not do that.
While at it, I removed the distinction between volatile and nonvolatile
window partition/order expressions: the code now computes all of them
at the aggregation level. This saves a relatively expensive check for
volatility, and it's unclear that the resulting plan isn't better anyway.
Per bug #7535 from Louis-David Mitterrand. Back-patch to 9.2.
Branch
------
REL9_2_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/269dbaf7076c96b3301abb7571fde42e183bf363
Modified Files
--------------
src/backend/optimizer/plan/planner.c | 163 +++++++++++++++++++++++++---------
src/test/regress/expected/window.out | 12 +++
src/test/regress/sql/window.sql | 6 ++
3 files changed, 137 insertions(+), 44 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2012-09-13 17:44:34 | pgsql: Keep plperl's current_call_data record on the stack, instead of |
Previous Message | Kevin Grittner | 2012-09-13 03:34:49 | pgsql: Fix typo in comment for pclose_check() function. |