pgsql: Add CheckTableNotInUse calls in DROP TABLE and DROP INDEX.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Add CheckTableNotInUse calls in DROP TABLE and DROP INDEX.
Date: 2011-02-15 20:51:07
Message-ID: E1PpRrX-0007hq-Cc@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add CheckTableNotInUse calls in DROP TABLE and DROP INDEX.

Recent releases had a check on rel->rd_refcnt in heap_drop_with_catalog,
but failed to cover the possibility of pending trigger events at DROP time.
(Before 8.4 we didn't even check the refcnt.) When the trigger events were
eventually fired, you'd get "could not open relation with OID nnn" errors,
as in recent report from strk. Better to throw a suitable error when the
DROP is attempted.

Also add a similar check in DROP INDEX.

Back-patch to all supported branches.

Branch
------
REL8_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/a580bffa08861dcbb25fb63c89654a9695484b4c

Modified Files
--------------
src/backend/catalog/heap.c | 7 +++++++
src/backend/catalog/index.c | 6 ++++++
2 files changed, 13 insertions(+), 0 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-02-15 21:05:59 Re: pgsql: Adjust pg_upgrade error message, array freeing, and add error ch
Previous Message Bruce Momjian 2011-02-15 20:00:49 pgsql: Adjust pg_upgrade error message, array freeing, and add error ch