| From: | Shinya Kato <shinya11(dot)kato(at)gmail(dot)com> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | wenhui qiu <qiuwenhuifx(at)gmail(dot)com>, Sami Imseih <samimseih(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Report oldest xmin source when autovacuum cannot remove tuples |
| Date: | 2026-05-23 05:22:48 |
| Message-ID: | CAOzEurS5s9cbXP7XT0EHe9KynLqsjJt56mqL+ZAPKD0jvrYPBw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, May 23, 2026 at 10:40 AM Japin Li <japinli(at)hotmail(dot)com> wrote:
> Thanks for updating the patch. LGTM. Just one nitpick.
>
> + int pid; /* backend pid (0 for slots) */
>
> Per the code, the prepared transaction is also associated with a PID of zero.
Thanks for the review! You're right, prepared transactions also have
pid 0. Fixed the comment to mention that.
Additionally, I forgot to update meson.build, which caused the tests
to fail. I have fixed that in the attached patch.
--
Best regards,
Shinya Kato
NTT OSS Center
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Report-oldest-xmin-blocker-when-VACUUM-cannot-rem.patch | application/octet-stream | 27.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shinya Kato | 2026-05-23 06:00:33 | Re: Report oldest xmin source when autovacuum cannot remove tuples |
| Previous Message | Chengpeng Yan | 2026-05-23 02:42:37 | Re: [PATCH] Fix overflow and underflow in regr_r2() |