Re: Don't wake up to check trigger file if none is configured

From: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Don't wake up to check trigger file if none is configured
Date: 2018-11-25 17:57:15
Message-ID: CAMkU=1zudXwGfYEs_ctbiCxayzmA2DKJLf472C6UapiAzPGOtQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Nov 24, 2018 at 11:29 AM Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:

> A streaming replica waiting on WAL from the master will wake up every 5
> seconds to check for a trigger file. This is pointless if no trigger file
> has been configured.
>
> The attached patch suppresses the timeout when there is no trigger file
> configured.
>

Rebased over the removal of recovery.conf and renaming of TriggerFile.

If the promote_trigger_file param is someday made responsive to SIGHUP, I
think this will just continue to do the right thing without further
modification.

Cheers,

Jeff

Attachment Content-Type Size
WAL_sleep_not_triggered_v2.patch application/octet-stream 1.0 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Laurenz Albe 2018-11-25 18:13:50 Re: Updated backup APIs for non-exclusive backups
Previous Message Tom Lane 2018-11-25 17:56:22 Re: pgsql: Add WL_EXIT_ON_PM_DEATH pseudo-event.