Skip site navigation (1) Skip section navigation (2)

Re: gripes

From: Josh Kupershmidt <schmiddy(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: gripes
Date: 2011-09-02 22:05:02
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
On Thu, Sep 1, 2011 at 9:25 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Committed, with some changes.  I used the new --if-exists option for
> dropdb rather than doing it as you had it here; I assume this may have
> been the motivation for that patch.

Thanks, and that was indeed one reason I wanted dropdb --if-exists.

> I also just made the exit code 1
> no matter how many failures there were.  That seems more normal, and I
> wasn't altogether certain that $((expr)) is completely portable.

Yeah, I wasn't sure about that either. The old book "The Unix
Programming Environment" (section "Arithmetic in sh") claims that
using expr or bc is the only way to do such arithmetic, e.g.:
  var=`expr $var + 1`

But then [1] documents arithmetic expansion as used in the patch. But
anyway, just returning 1 as you've done seems fine.



In response to

pgsql-hackers by date

Next:From: Peter EisentrautDate: 2011-09-02 22:37:17
Subject: Re: pg_upgrade automatic testing
Previous:From: Josh BerkusDate: 2011-09-02 21:54:53
Subject: Re: CF2011-09

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group