| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Zhenwei Shang <a934172442(at)gmail(dot)com> |
| Cc: | Afrah Razzak <mypg(dot)afrah(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] psql: Add missing IO option to EXPLAIN tab completion |
| Date: | 2026-05-23 00:41:21 |
| Message-ID: | CAHGQGwHPA_Zc0=-p8Fc=n1HXwf0UABp=XWCyq9r3vPca7ajDGQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 13, 2026 at 2:49 PM Zhenwei Shang <a934172442(at)gmail(dot)com> wrote:
>
>
>
> Afrah Razzak <mypg(dot)afrah(at)gmail(dot)com> 于2026年5月13日周三 11:35写道：
>>
>> Hi,
>>
>> Commit 681daed9316 added EXPLAIN (IO) as a new boolean option, but
>> psql's tab completion was not updated to include it.
>>
>> Currently:
>>
>> EXPLAIN (<Tab> -- IO is not listed
>> EXPLAIN (IO <Tab> -- no ON/OFF offered
>>
>> The attached patch adds IO to both the option keyword list and the
>> boolean ON/OFF completion pattern in tab-complete.in.c.
>>
>> Thanks,
>> Afrah Razzak
>>
> Looks correct to me. EXPLAIN (IO) is a boolean option, so adding it to both the option keyword list and the ON/OFF completion branch is the right fix.
I've pushed the patch. Thanks!
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chengpeng Yan | 2026-05-23 01:14:09 | Re: [PATCH] Fix overflow and underflow in regr_r2() |
| Previous Message | Chao Li | 2026-05-22 23:56:32 | Re: Set notice receiver before libpq connection startup |