Re: DNS SRV support for LDAP authentication

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: DNS SRV support for LDAP authentication
Date: 2019-02-16 09:56:23
Message-ID: CAEepm=1a4MejOOA65f0XdBR+5GBqpRpLvgSX9wkMbBCXJ3Sw4Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Sat, Feb 2, 2019 at 12:48 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> + new_uris = psprintf("%s%s%s://%s:%d",
>
> While this construction isn't introduced in this patch, would it not make sense
> to convert uris to StringInfo instead to improve readability?

Yeah. This coding is ugly and StringInfo would be much nicer.
Thinking about that made me realise that the proposed SRV case should
also handle multiple SRV records by building a multi-URL string too
(instead of just taking the first one). I will make it so.

--
Thomas Munro
http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2019-02-16 10:14:21 Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.
Previous Message Vladimir Sitnikov 2019-02-16 09:36:45 Re: [Patch][WiP] Tweaked LRU for shared buffers