Re: add modulo (%) operator to pgbench

From: Mitsumasa KONDO <kondo(dot)mitsumasa(at)gmail(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: add modulo (%) operator to pgbench
Date: 2014-09-08 14:22:56
Message-ID: CADupcHW7aYvQ-aCo_Upehnk4u29j15wco6JrDfbavd_T9Qi10Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Fabien-san,

Thank you for your fast work!

2014-09-08 23:08 GMT+09:00 Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>:

>
> Hello Mutsumara-san,
>
> #3. Documentation
>> I think modulo operator explanation should put at last at the doc line.
>> Because the others are more frequently used.
>>
>
> So I like patch3 which is simple and practical.
>>
>
> Ok.
>
> If you agree or reply my comment, I will mark ready for commiter.
>>
>
> Please find attached v4, which is v3 plus an improved documentation
> which is clearer about the sign of the remainder.

The attached is seemed no problem. But I'd like to say about order of
explanation in five formulas.

Fix version is here. Please confirm, and I mark it for ready for commiter.

Best regards,
--
Mitsumasa KONDO

Attachment Content-Type Size
pgbench-modulo-4-1.patch application/octet-stream 1.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-09-08 14:29:52 Re: Spinlocks and compiler/memory barriers
Previous Message Bruce Momjian 2014-09-08 14:18:11 Re: Spinlocks and compiler/memory barriers