Re: Making tab-complete.c easier to maintain

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Making tab-complete.c easier to maintain
Date: 2016-01-01 12:10:48
Message-ID: CAB7nPqSCekNhu67cM3GYqnrKyvM3SdXr97URbeA3BY7XoKwWJw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 31, 2015 at 9:13 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Wed, Dec 30, 2015 at 11:21 PM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:
>> Michael Paquier wrote:
>>
>>> OK, here are new patches.
>>> - 0001 switches a bunch of TailMatches to Matches. Do we want to care
>>> about the case where a schema is created following by a bunch of
>>> objects? I mean stuff like "CREATE SCHEMA hoge CREATE TABLE ..." where
>>> the current completion would work fine. The performance gains seem
>>> worth it compared to the number of people actually using it, the point
>>> has just not been raised yet.
>>
>> I'd rather have the completion work for that case than get a few
>> microseconds speedup. As far as I recall, it's only four commands that
>> must retain the old coding.
>
> Fine for me this way.

So, here are the commands that still remain with TailMatches to cover
this case, per gram.y:
- CREATE TABLE
- CREATE INDEX
- CREATE VIEW
- GRANT
- CREATE TRIGGER
- CREATE SEQUENCE
New patches are attached.
Regards,
--
Michael

Attachment Content-Type Size
0001-Improve-performance-of-psql-tab-completion.patch text/x-patch 55.9 KB
0002-Adopt-more-compact-tab-completion-for-backslash-comm.patch text/x-patch 15.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2016-01-01 12:41:33 Re: Some 9.5beta2 backend processes not terminating properly?
Previous Message Oleg Bartunov 2016-01-01 11:20:16 strange behaviour of psql \e command