Re: Adding in docs the meaning of pg_stat_replication.sync_state

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Adding in docs the meaning of pg_stat_replication.sync_state
Date: 2016-12-06 05:13:23
Message-ID: CAB7nPqQLQa2B-P_JO_79m=mbG-PCTY1qo03p7eV1qQ31-4gytg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 6, 2016 at 1:54 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> + <literal>backup</>: The WAL sender is sending a backup.
>
> Seems it's better to use "This WAL sender" rather than "The WAL sender"
> like the descriptions of other fields.
>
> There are two descriptions of "streaming" value. You need to remove
> either of them.
>
> + <literal>streaming</>: The WAL sender is catching up with the
> + primary.
>
> "walsender is catching up with the primary" sounds a bit strange to me.
> What about "This WAL sender's connected standby server is catching up
> with the primary"?
>
> + <literal>streaming</>: The WAL sender has caught up with the
> + primary and is streaming changes.
>
> Same as above.

Agreed with all that. Attached is an updated version.
--
Michael

Attachment Content-Type Size
sync-state-docs-v2.patch text/x-patch 2.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joseph Brenner 2016-12-06 05:28:11 Re: Select works only when connected from login postgres
Previous Message David G. Johnston 2016-12-06 05:03:42 Re: Select works only when connected from login postgres