Re: Assertion failure with barriers in parallel hash join

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Assertion failure with barriers in parallel hash join
Date: 2021-03-31 22:41:12
Message-ID: CAAKRu_ZSdynXbzR=5Nb5kQ3QdsUBs0=Cp6a4YxUkbMrX9mmR_g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 17, 2021 at 8:18 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>
> On Wed, Mar 17, 2021 at 6:58 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > According to BF animal elver there is something wrong with this
> > commit. Looking into it.
>
> Assertion failure reproduced here and understood, but unfortunately
> it'll take some more time to fix this. I've reverted the commit for
> now to unbreak the ~5 machines that are currently showing red in the
> build farm.

Also, silly question: why couldn't we just set the pstate->batches pointer to
InvalidDsaPointer before doing dsa_free() (of course saving the pointer
so that we can actually do the freeing with it)? Is there still a race?

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhihong Yu 2021-03-31 22:53:45 Re: Crash in BRIN minmax-multi indexes
Previous Message Tom Lane 2021-03-31 22:31:45 Re: libpq debug log