Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file
Date: 2015-07-02 05:16:08
Message-ID: CAA4eK1Lb1DLNf9HB-TZho4N92BvtTBaqCHh+0JwCWwtATi9qEw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sat, Jun 27, 2015 at 12:54 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> On Mon, Jun 15, 2015 at 2:52 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
wrote:
> > Attached patch provides a fix as per above discussion.
>
> I think we should emit some LOG messages here. When we detect the
> file is there:
>
> LOG: ignoring tablespace_map file because no backup_label file exists
>
> If the rename fails:
>
> LOG: could not rename file "%s" to "%s": %m
>
> If it works:
>
> LOG: renamed file "%s" to "%s"
>

Added the above log messages in attached patch with small change
such that in message, file names will be displayed with quotes as most
of other usages of rename (failure) in that file uses quotes to display
filenames.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
rename_mapfile_if_backupfile_not_present_v2.patch application/octet-stream 1.6 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2015-07-02 09:15:58 pgsql: Use American spelling for "behavior".
Previous Message Andrew Dunstan 2015-07-02 03:32:19 pgsql: Allow MSVC's contribcheck and modulescheck to run independently.

Browse pgsql-hackers by date

  From Date Subject
Next Message Kouhei Kaigai 2015-07-02 05:21:39 Re: ctidscan as an example of custom-scan (Re: [v9.5] Custom Plan API)
Previous Message Michael Paquier 2015-07-02 05:10:50 Re: Support for N synchronous standby servers - take 2