From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | John Naylor <john(dot)naylor(at)2ndquadrant(dot)com> |
Cc: | Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: WIP: Avoid creation of the free space map for small tables |
Date: | 2019-01-24 03:44:19 |
Message-ID: | CAA4eK1KNb54AX8yw7e4V7FQXhkmTeEBqKv-nMhdMb611a1cSpA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jan 23, 2019 at 9:18 PM John Naylor <john(dot)naylor(at)2ndquadrant(dot)com> wrote:
>
> On Wed, Jan 23, 2019 at 7:09 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > I think the first two patches (a) removal of dead code in bootstrap
> > and (b) the core patch to avoid creation of FSM file for the small
> > table are good now. I have prepared the patches along with commit
> > message. There is no change except for some changes in README and
> > commit message of the second patch. Kindly let me know what you think
> > about them?
>
> Good to hear! The additional language is fine. In "Once the FSM is
> created for heap", I would just change that to "...for a heap".
>
Sure, apart from this I have run pgindent on the patches and make some
changes accordingly. Latest patches attached (only second patch has
some changes). I will take one more pass on Monday morning (28th Jan)
and will commit unless you or others see any problem.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
v02-0001-In-bootstrap-mode-don-t-allow-the-creation-of-files-.patch | application/octet-stream | 2.7 KB |
v18-0002-Avoid-creation-of-the-free-space-map-for-small-heap-.patch | application/octet-stream | 40.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-01-24 03:53:24 | Re: Thread-unsafe coding in ecpg |
Previous Message | Tom Lane | 2019-01-24 03:10:04 | Re: Thread-unsafe coding in ecpg |