Re: libpq compression

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, rharwood(at)redhat(dot)com, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, g(dot)smolkin(at)postgrespro(dot)ru, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: libpq compression
Date: 2018-11-29 19:13:25
Message-ID: CA+q6zcVaT=m-Py-R2ap0oZDEWxUkKR9hFqDpVNNtHTGTkbd75g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

> On Mon, Aug 13, 2018 at 8:48 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> I agree with the critiques from Robbie Harwood and Michael Paquier
> that the way in that compression is being hooked into the existing
> architecture looks like a kludge. I'm not sure I know exactly how it
> should be done, but the current approach doesn't look natural; it
> looks like it was bolted on.

After some time spend reading this patch and investigating different points,
mentioned in the discussion, I tend to agree with that. As far as I see it's
probably the biggest disagreement here, that keeps things from progressing. I'm
interested in this feature, so if Konstantin doesn't mind, I'll post in the
near future (after I'll wrap up the current CF) an updated patch I'm working on
right now to propose another way of incorporating compression. For now I'm
moving patch to the next CF.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sergei Agalakov 2018-11-29 19:16:09 Re: [PROPOSAL] extend the object names to the qualified names in pg_stat_statements
Previous Message Tom Lane 2018-11-29 19:13:07 Re: "SELECT ... FROM DUAL" is not quite as silly as it appears