| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Rafia Sabih <rafia(dot)sabih(at)enterprisedb(dot)com>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parallel bitmap heap scan |
| Date: | 2017-02-07 21:36:55 |
| Message-ID: | CA+Tgmoa6Rah_i4VUYi-AEZOTj5BQxGsWvWo4AAT3Dm7zBD2nzQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 7, 2017 at 4:15 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> FWIW, I think it'd have been better to not add the new callbacks as
> parameters to *_create(), but rather have them be "templatized" like the
> rest of simplehash. That'd require that callback to check the context,
> to know whether it should use shared memory or not, but that seems fine
> to me. Right now this pushes the head of simplehash above a
> cacheline...
Something like the attached?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| rework-simplehash-allocator.patch | application/octet-stream | 5.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Banck | 2017-02-07 21:39:13 | Re: Press Release Draft - 2016-02-09 Cumulative Update |
| Previous Message | Robert Haas | 2017-02-07 21:19:48 | Re: Parallel bitmap heap scan |