Skip site navigation (1) Skip section navigation (2)

Re: wxWidgets 2.9 build

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: wxWidgets 2.9 build
Date: 2011-01-26 13:57:05
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgadmin-hackers
On Wed, Jan 26, 2011 at 12:56 PM, Peter Geoghegan
<peter(dot)geoghegan86(at)gmail(dot)com> wrote:
> On 26 January 2011 09:15, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> We don't support non-unicode builds any more, so you might as well
>> just inline the mb_str call where it's needed, and lose the rest.
> Okay, I removed the entire function.


> I had another look at our Flex/Bison problem. Look at this diff
> output, after a fresh run of
> diff --git a/pgadmin/include/pgscript/
> b/pgadmin/include/pgscript/
> --- a/pgadmin/include/pgscript/
> +++ b/pgadmin/include/pgscript/
>  #include <string>
>  #include <iostream>
>  #include "stack.hh"
> -#include "pgscript/pgScript.h"
> -#include "pgscript/statements/pgsStatements.h"
> -#include "pgscript/expressions/pgsExpressions.h"
> -#include "pgscript/objects/pgsObjects.h"
> -#include "pgscript/utilities/pgsContext.h"
>  #include "location.hh"
> Restoring this by hacking the header doesn't quite fix the problem.
> More headers must be hacked, where there doesn't appear to have been
> headers removed. This may be symptomatic of a particular problem that
> someone that really groks Flex++/Bison may be able to identify. What
> do you think?

Seems like a reasonable assumption - but I'm not that flex/bison
person unfortunately. Is there a mailing list for those tools?

> Regarding warnings, some cross-platform projects standardise on fixing
> all warnings for a particular preferred platform. I thought you might
> not appreciate fixes for warnings that you presumably don't even see
> on your system (otherwise you'd have fixed them yourself), that crop
> up quite a lot, on top of an already fairly extensive patch. I'll fix
> them though.

Personally, I expect zero warnings on any platform I work on. I
currently test on OS X Snow Leopard, CentOS 5.5 and Windows 7 with
VC++ 2008.

Dave Page
Twitter: @pgsnake

EnterpriseDB UK:
The Enterprise PostgreSQL Company

In response to


pgadmin-hackers by date

Next:From: Peter GeogheganDate: 2011-01-26 15:40:54
Subject: Re: wxWidgets 2.9 build
Previous:From: Peter GeogheganDate: 2011-01-26 12:56:58
Subject: Re: wxWidgets 2.9 build

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group