Re: PassDownLimitBound for ForeignScan/CustomScan

From: Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>
To: Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "Etsuro Fujita" <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
Subject: Re: PassDownLimitBound for ForeignScan/CustomScan
Date: 2016-09-13 07:48:14
Message-ID: 9A28C8860F777E439AA12E8AEA7694F8012297C0@BPXM15GP.gisp.nec.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Sorry for my late.

The attached patch fixed the wording problems on SGML part.

Best regards,
--
NEC Business Creation Division / PG-Strom Project
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>

> -----Original Message-----
> From: Jeevan Chalke [mailto:jeevan(dot)chalke(at)enterprisedb(dot)com]
> Sent: Tuesday, September 06, 2016 11:22 PM
> To: Kaigai Kouhei(海外 浩平)
> Cc: pgsql-hackers(at)postgresql(dot)org; Etsuro Fujita
> Subject: Re: [HACKERS] PassDownLimitBound for ForeignScan/CustomScan
>
> Hi,
>
> Changes look good to me.
>
> However there are couple of minor issues need to be fixed.
>
> 1.
> "under" repeated on second line. Please remove.
> + if and when <structname>CustomScanState</> is located under
> + under <structname>LimitState</>; which implies the underlying node is not
>
> 2.
> Typo: dicsussion => discussion
> Please fix.
>
> Apart from this I see no issues.
>
>
> Thanks
>
>
> --
>
> Jeevan B Chalke
> Principal Software Engineer, Product Development
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
pgsql-v10-fdw-css-limit-bound.v3.patch application/octet-stream 6.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-09-13 08:08:12 Re: CVE-2016-1238 fix breaks (at least) pg_rewind tests
Previous Message Michael Paquier 2016-09-13 07:43:52 Re: Refactoring of heapam code.