Skip site navigation (1) Skip section navigation (2)

Re: Buglets in dlgFunction

From: "Dave Page" <dpage(at)pgadmin(dot)org>
To: "Guillaume Lelarge" <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Buglets in dlgFunction
Date: 2008-10-18 07:38:04
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgadmin-hackers
On Thu, Oct 16, 2008 at 3:38 PM, Guillaume Lelarge
<guillaume(at)lelarge(dot)info> wrote:

> Here is a new (complete) patch. I don't like at all what I did but it
> seems to fix your issues.

OK, here we go....


Existing table: OK
New table: OK


Existing sequence: OK
New sequence: OK


New database: OK
Existing database: OK


Existing package: OK
New package: OK


New tablespace: OK
Existing tablespace: OK


Existing schema: OK
New schema: OK


Existing view: OK
New view: OK

Nice work!! So, let's please get this applied so we can put it to bed.
A couple of minor fixes:

- In dlgFunction::Go @367, you have:

    returncode = dlgSecurityProperty::Go(modal);

    returncode = dlgSecurityProperty::Go(modal);

Copy/paste error?

- Please add a comment to each instance of the ugly resize blocks to
explain what it's doing so we don't forget in 6 months :-)


Dave Page
EnterpriseDB UK:

In response to


pgadmin-hackers by date

Next:From: Gevik BabakhaniDate: 2008-10-18 21:43:27
Subject: Re: extending functionality strategy
Previous:From: Guillaume LelargeDate: 2008-10-17 12:05:39
Subject: Re: Buglets in dlgFunction

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group