From: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com> |
---|---|
To: | Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it>, Craig Ringer <craig(at)2ndquadrant(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] session_replication_role = replica with TRUNCATE |
Date: | 2018-01-17 16:33:07 |
Message-ID: | 87fa890c-a8ca-50b0-ff40-f83a8acc1e45@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 02/01/18 17:16, Marco Nenciarini wrote:
> Hi,
>
> I've tried to amend the documentation to be more clear. Feel free to
> suggest further editing. Patch v2 attached.
>
I think the patch as is now looks okay. So marking as ready for committer.
This is noteworthy for the release notes though as it's behavior change
compared to old versions.
> Regards,
> Marco
>
> P.S: I'm struggling to understand why we have two possible values of
> session_replication_role settings that behave identically (origin and
> local). I'm unable to see any difference according to the code or the
> documentation, so I'm wondering if we should document that they are the
> same.
>
It's for use by 3rd party tools (afaik both londiste and slony use it)
to differentiate between replicated and not replicated changes.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-01-17 16:33:09 | Re: master make check fails on Solaris 10 |
Previous Message | Graham Leggett | 2018-01-17 16:10:00 | Re: Is there a "right" way to test if a database is empty? |