| From: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pageinspect: Hash index support |
| Date: | 2016-09-27 14:10:42 |
| Message-ID: | 836487ee-8d4e-cd49-54ac-f4793ddba5ae@redhat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 09/26/2016 10:45 PM, Peter Eisentraut wrote:
> On 9/26/16 1:39 PM, Jesper Pedersen wrote:
>> Left as is, since BuildTupleFromCStrings() vs. xyzGetDatum() are equally
>> readable in this case. But, I can change the patch if needed.
>
> The point is that to use BuildTupleFromCStrings() you need to convert
> numbers to strings, and then they are converted back. This is not a
> typical way to write row-returning functions.
>
Ok.
Changed:
* BuildTupleFromCStrings -> xyzGetDatum
* 'type' field: char -> text w/ full description
* Removed 'type' information from documentation
Best regards,
Jesper
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-pageinspect-Hash-index-support_v7.patch | text/x-patch | 35.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-09-27 14:11:38 | Re: Showing parallel status in \df+ |
| Previous Message | Robert Haas | 2016-09-27 14:08:14 | Re: Parallel tuplesort (for parallel B-Tree index creation) |