Re: [HACKERS] Additional logging for VACUUM and ANALYZE

From: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Fabrízio Mello <fabriziomello(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Additional logging for VACUUM and ANALYZE
Date: 2017-12-01 21:05:05
Message-ID: 7EA13C25-BC89-4998-8541-F143C56BE0C5@amazon.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 12/1/17, 2:03 PM, "Robert Haas" <robertmhaas(at)gmail(dot)com> wrote:
> Thanks. I think this looks fine now, except that (1) it needs a
> pgindent run and (2) I vote for putting the test case back. Michael
> thought the test case was too much because this is so obscure, but I
> think that's exactly why it needs a test case. Otherwise, somebody a
> few years from now may not even be able to figure out how to hit this
> message, and if it gets broken, we won't know. This code seems to be
> fairly easy to break in subtle ways, so I think more test coverage is
> good.

Makes sense. I ran pgindent and re-added the test case for v6 of the
patch.

Nathan

Attachment Content-Type Size
new_vacuum_log_messages_v6.patch application/octet-stream 8.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2017-12-01 21:06:00 Re: [HACKERS] Custom compression methods
Previous Message Robert Haas 2017-12-01 21:03:59 Re: BUG #14941: Vacuum crashes