Re: fix integer datetime division rounding error

From: "Rocco Altier" <RoccoA(at)Routescape(dot)com>
To: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>, "Andrew Dunstan" <andrew(at)dunslane(dot)net>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fix integer datetime division rounding error
Date: 2005-07-24 05:41:47
Message-ID: 6E0907A94904D94B99D7F387E08C4F5730ECAC@FALCON.INSIGHT
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

This fixes the problem for me.

Thanks,
-rocco

> -----Original Message-----
> From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
> Sent: Sunday, July 24, 2005 12:37 AM
> To: Andrew Dunstan
> Cc: Patches (PostgreSQL); Rocco Altier
> Subject: Re: [PATCHES] fix integer datetime division rounding error
>
>
> Andrew Dunstan wrote:
> >
> > The attached patch seems to fix the rounding error that is causing
> > regression failures on machines with integer datetimes.
> (Source of error
> > discovered by Andrew(at)Supernews).ISTM this code needs to be
> given some
> > careful analysis - I know it makes my head spin reading it.
>
> Ah, brilliant! I knew I was missing something fundamental,
> and the use
> of rint() was it. Strangely enough, the 8.0 code uses rint() in that
> function, but for floating point intervals, and the code was buggy,
> generating negative time values for division.
>
> Patch attached and applied. I also improved the interval
> multiplication
> code.
>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
> + If your life is a hard drive, | 13 Roberts Road
> + Christ can be your backup. | Newtown Square,
> Pennsylvania 19073
>

Browse pgsql-patches by date

  From Date Subject
Next Message Rocco Altier 2005-07-24 05:49:26 Regression - GNUmakefile - pg_usleep
Previous Message Bruce Momjian 2005-07-24 04:37:08 Re: fix integer datetime division rounding error