Re: zic with msvc

From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <pgsql-hackers(at)postgresql(dot)org>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: zic with msvc
Date: 2006-10-20 18:15:28
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCEA0FCA8@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> > + #ifdef WIN32
> > + #define _WIN32_WINNT 0x0400
> > + #endif
>
> Hmm ... in pg_ctl.c I see
>
> #define _WIN32_WINNT 0x0500
>
> Is there a reason for these to be different? Are there other
> places that will need this (ie, maybe it should be in c.h instead?)

Not really. The default appears to be 0x0400 for MingW (or it wouldn't
have worked before), but 0x0350 or so for Visual C++.
If we define it to 0x0500 we pull in headers that will only work on 2000
or newer. But I don't really see that as a problem - I think we said
that we don't care about earlier ones anyway. in which case it's
definitly not a problem to stick it in c.h.

//Magnus

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-10-20 18:21:04 Re: [SPAM?] Re: Asynchronous I/O Support
Previous Message Theo Schlossnagle 2006-10-20 18:12:55 Re: xlogdump fixups and WAL log question.

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2006-10-20 23:57:35 Updates for vcbuild
Previous Message Tom Lane 2006-10-20 18:06:46 Re: zic with msvc