Re: Replication identifiers, take 4

From: Petr Jelinek <petr(at)2ndquadrant(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Cc: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Robert Haas <robertmhaas(at)gmail(dot)com>, Steve Singer <steve(at)ssinger(dot)info>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Replication identifiers, take 4
Date: 2015-04-29 20:14:36
Message-ID: 55413BAC.1000901@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 29/04/15 22:12, David Rowley wrote:
> On 25 April 2015 at 00:32, Andres Freund <andres(at)anarazel(dot)de
> <mailto:andres(at)anarazel(dot)de>> wrote:
>
>
> Attached is a patch that does this, and some more, renaming. That was
> more work than I'd imagined. I've also made the internal naming in
> origin.c more consistent/simpler and did a bunch of other cleanup.
>
>
> Hi,
>
> It looks like bowerbird is not too happy with this, neither is my build
> environment.
>
> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2015-04-29%2019%3A31%3A06
>
> The attached seems to fix it.
> I put the include in the origin.h rather than in the origin.c as the
> DoNotReplicateId macro uses UINT16_MAX and is also used in xact.c.
>

I think correct fix is using PG_UINT16_MAX.

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-04-29 20:52:46 Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API)
Previous Message David Rowley 2015-04-29 20:12:14 Re: Replication identifiers, take 4