Re: BUG #5837: PQstatus() fails to report lost connection

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: "Murray S(dot) Kucherawy" <msk(at)cloudmark(dot)com>, "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Robert Haas" <robertmhaas(at)gmail(dot)com>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #5837: PQstatus() fails to report lost connection
Date: 2011-01-24 18:47:18
Message-ID: 4D3D74D60200002500039B3C@gw.wicourts.gov
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

"Murray S. Kucherawy" <msk(at)cloudmark(dot)com> wrote:
> From: Kevin Grittner [mailto:Kevin(dot)Grittner(at)wicourts(dot)gov]

>> What do you think would make this more clear?

> So maybe something like this after the paragraph you cited would
> help:
>
> "Note that after returning a PGresult object, PQresultStatus()
> could indicate a fatal error. The caller should still iterate
> calling PQgetResult() to completion (i.e. until it returns NULL)
> in order to allow libpq to process the error information
> completely."

A patch based on this suggestion attached for consideration by the
community.

-Kevin

Attachment Content-Type Size
PQgetResult-doc.patch text/plain 687 bytes

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Murray S. Kucherawy 2011-01-24 18:48:25 Re: BUG #5837: PQstatus() fails to report lost connection
Previous Message Murray S. Kucherawy 2011-01-24 18:14:43 Re: BUG #5837: PQstatus() fails to report lost connection