Re: pgsql: Minor improvement: avoid assuming that GetLastError value cannot

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Minor improvement: avoid assuming that GetLastError value cannot
Date: 2009-05-06 13:39:33
Message-ID: 4A019315.5050707@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Any reason you didn't backport this to the other versions that got the
>> SetLastError() fix?
>
> AFAIK it's just a cosmetic improvement. If you think there's a
> significant risk then back-port away...

Not really, but it'd be easier if we need to backpatch more stuff later
if the source files are the same at least :-)

//Magnus

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2009-05-06 16:15:21 pgsql: Modify CREATE DATABASE to enforce that the source database's
Previous Message Tom Lane 2009-05-06 13:38:09 Re: pgsql: Minor improvement: avoid assuming that GetLastError value cannot