Skip site navigation (1) Skip section navigation (2)

Re: WAL recovery is broken by FSM patch

From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: WAL recovery is broken by FSM patch
Date: 2008-10-01 08:13:39
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
Tom Lane wrote:
> I just managed to make a backend dump core while fooling with the CTE
> patch, and found out that the system failed to recover, because the
> ensuing startup process *also* dumped core.  Here's the backtrace:
> ...
> We should of course not be attempting XLogInsert during WAL replay.
> Now smgr_redo knows about that.  I rather wonder why fsm_redo is
> attempting to call smgrtruncate at all, seeing that there's presumably
> smgr's own redo record to tell it to deal with that.  I think that all
> fsm_redo need do is clear out the last untruncated block of FSM.

Agreed. Fixed, thanks.

   Heikki Linnakangas

In response to

pgsql-hackers by date

Next:From: Simon RiggsDate: 2008-10-01 08:18:49
Subject: Plans for Hot Standby
Previous:From: Albe LaurenzDate: 2008-10-01 07:01:08
Subject: Re: Block-level CRC checks

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group