Re: Latest ecpg patch broke MSVC build

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>, ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Latest ecpg patch broke MSVC build
Date: 2007-10-01 03:51:11
Message-ID: 47006EAF.9030301@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>> It is building with thread.c but it should not be unless I am misreading
>> the Makefile. The makefile processing in Project.pm doesn't look nearly
>> powerful enough to handle this:
>>
>
>
>> # thread.c is needed only for non-WIN32 implementation of path.c
>> ifneq ($(PORTNAME), win32)
>> OBJS += thread.o
>> endif
>>
>
> Hmm, sounds like a problem, but why was it not a problem before?
>
>
>

Good point. I don't know. I guess something else must be causing the
build failure.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message D'Arcy J.M. Cain 2007-10-01 06:53:57 Re: adding operators
Previous Message Tom Lane 2007-10-01 03:46:00 Re: Latest ecpg patch broke MSVC build