Re: UTF8MatchText

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: UTF8MatchText
Date: 2007-05-18 15:43:49
Message-ID: 464DC9B5.8050803@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
>
>> Yes, I only used the 'disjoint representations for first-bytes and
>> not-first-bytes of MB characters' feature in UTF8. Other encodings
>> allows both [AB] and [BA] for MB character patterns. UTF8Match() does
>> not cope with those encodings; If we have '[AB][AB]' in a table and
>> search it with LIKE '%[BA]%', we judge that they are matched by mistake.
>>
>
> AFAICS, the patch does *not* make that mistake because % will not
> advance over a fractional character.
>
>
>

Unless I hear differently, my present intention is to apply the
suggested improvement universally. I'll wait a day or two before
completing the patch.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2007-05-18 16:05:55 Signing off of patches (was Re: Not ready for 8.3)
Previous Message Heikki Linnakangas 2007-05-18 15:19:18 Re: Maintaining cluster order on insert

Browse pgsql-patches by date

  From Date Subject
Next Message Zoltan Boszormenyi 2007-05-18 19:50:57 Standard compliant DEFAULT clause
Previous Message Heikki Linnakangas 2007-05-18 15:19:18 Re: Maintaining cluster order on insert